Arx Libertatis Bug Tracker
star_faded.png
Please log in to bookmark issues
feature_request_small.png
CLOSED  Feature request #1521  -  Modes for Borderless, Full Screen, and Windowed
Posted Jan 12, 2021 - updated Jan 12, 2021   Shortlink: http://arx.vg/1521
action_vote_minus_faded.png
0
Votes
 action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Not a bug" and resolution "CAN'T REPRODUCE".
Issue details
  • Type of issue
    Feature request
  • Status
     
    		 Not a bug
  • Assigned to
    Not assigned to anyone
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
    Guest user
  • Owned by
    Not owned by anyone
  • Estimated time
    Not estimated
  • Category
    Not determined
  • Resolution
    CAN'T REPRODUCE
  • Priority
    Not determined
  • Targetted for
    icon_milestones.png Not determined
  • OS
    icon_customdatatype.png Not determined
  • Architecture
    icon_customdatatype.png Not determined
  • Fixed in
    icon_customdatatype.png Not determined
Issue description
In the current version of the engine, the full screen started at a very small resolution by default, until setup to use the desktop resolution.

I made a patch to use borderless full screen mode instead of desktop full screen, which worked around the issue.

An additional feature could be to offer an option to toggle this on and off, and to support windowed mode. 

  1. From 7ca5fb92a559a906d738fad860bead8a5ee07652 Mon Sep 17 00:00:00 2001
  2. From: d10sfan <d10sfan@gmail.com>
  3. Date: Wed, 1 Jul 2020 23:53:32 -0500
  4. Subject: [PATCH] Use borderless full screen
  5.  
  6. ---
  7.  src/window/SDL2Window.cpp | 2 +-
  8.  1 file changed, 1 insertion(+), 1 deletion(-)
  9.  
  10. diff --git a/src/window/SDL2Window.cpp b/src/window/SDL2Window.cpp
  11. index 13b63377d..e7ef089e8 100644
  12. --- a/src/window/SDL2Window.cpp
  13. +++ b/src/window/SDL2Window.cpp
  14. @@ -240,7 +240,7 @@ static Uint32 getSDLFlagsForMode(const Vec2i & size, bool fullscreen) {
  15.  		if(size == Vec2i(0)) {
  16.  			flags |= SDL_WINDOW_FULLSCREEN_DESKTOP;
  17.  		} else {
  18. -			flags |= SDL_WINDOW_FULLSCREEN;
  19. +			flags |= SDL_WINDOW_FULLSCREEN_DESKTOP;
  20.  		}
  21.  	}
  22.  
  23. -- 
  24. 2.27.0

#1
icon_reply.pngReply
Comment posted by
Daniel Scharrer
Jan 12, 05:46
In the current version of the engine, the full screen started at a very small resolution by default, until setup to use the desktop resolution.


"Desktop" resolution aka resolution="auto" in cfg.ini is already the default for Arx Libertatis master. The only time you get something different is if you manually changed the setting or have an existing cfg.ini.

I made a patch to use borderless full screen mode instead of desktop full screen, which worked around the issue.


Your patch just changes all modes to borderless fullscreen at the desktop resolution. Obviously that's not how those modes should work.

An additional feature could be to offer an option to toggle this on and off, and to support windowed mode.


You toggle borderless fullscreen by selecting the special "Desktop" resolution (borderless fullscreen) or explicitly choosing a resolution (exclusive fullscreen on those systems that support that). Windowed mode is also already supported by unchecking the "Full screen" checkbox in the video settings or by pressing Alt+Enter to switch between windowed mode or fullscreen.

The issue was updated with the following change(s):
  • The status has been updated, from New to Not a bug.
  • This issue has been closed
  • The resolution has been updated, from Not determined to CAN'T REPRODUCE.