Arx Libertatis Bug Tracker ~ [CLOSED] #1111

Arx Libertatis Bug Tracker

CLOSED Bug report #1111 - Item stack size glitch

Posted Dec 28, 2017 - updated Jul 11, 2021 Shortlink: http://arx.vg/1111

Votes

This issue has been closed with status "Fixed" and resolution "RESOLVED".

Issue details

Type of issue

Bug report Unknown issue type
Status

Fixed

Status not determined
Assigned to

Not assigned to anyone
Progress
Type of bug

Not triaged
Likelihood

Not triaged
Effect

Not triaged
Posted by

Daniel Scharrer

Daniel Scharrer
Offline

This user was last seen online at Apr 21, 2024 - 12:55

Show user details

Close this menu
Owned by

Not owned by anyone
Estimated time

No time Not estimated
Time spent

No time No time spent
Category

Not determined
Resolution

RESOLVED Not determined
Priority

Not determined
Reproducability

Not determined
Severity

Not determined
Targetted for

Not determined
OS

Not determined
Architecture

Not determined
Fixed in

Arx Libertatis 1.2Not determined

Issue description

For items with a max stack size of 10 is sometimes possible to stack one stack of 9 items onto another stack of 9 items, creating a stack of 18 items.

http://steamcommunity.com/app/1700/discussions/0/1621724915793377124/

Steps to reproduce this issue

Create a stack of 9 items in a chest
Create a stack of 9 items of the same type in your inventory
Drag the whole stack from your inventory using shift
Drop the dragged stack onto the stack in the chest but release shift just before you release the mouse button
With some luck the two stacks will be combined

Show system-generated comments

Comment posted on behalf of

Daniel Scharrer

Dec 28, 20:46

The issue was updated with the following change(s):

This issue's description has been changed

Comment posted on behalf of

Daniel Scharrer

Mar 22, 01:10

This issue has been updated with the latest changes from the code repository.

Inventory: Fix item stack size violation
 
When dropping an item stack into the secondary inventory (inventory of
a non-player entity) at a position we:
 1. Try to merge it with the existing stack at the dropped position.
 2. Insert it at the dropped position if the slot is empty
 3. Merge it into any stack of the same item in the inventory
 4. Insert it at the first empty slot
 
Step 3 did prevent merging into full stacks but did not check that the
combined size of the existing stack and the dropped stack does not
exceed the stack limit. Now it does.
 
Fixes: bug #1111

Comment posted by

Daniel Scharrer

Mar 22, 01:21

This happened when dropping an item onto a secondary inventory slot which contains a different item but a non-full stack of the dropped item type is somewhere else in the secondary inventory. Shift does not seem to make a difference.

The issue was updated with the following change(s):

This issue has been closed
The status has been updated, from New to Fixed.
The resolution has been updated, from Not determined to RESOLVED.
This issue's progression has been updated to 100 percent completed.

Comment posted by

Daniel Scharrer

Apr 01, 21:45

This should now be fixed in 1.2-dev-2020-04-01.

Comment posted on behalf of

Daniel Scharrer

Jun 25, 20:44

This issue has been updated with the latest changes from the code repository.

Inventory: Fix item stack size violation
 
When dropping an item stack into the secondary inventory (inventory of
a non-player entity) at a position we:
 1. Try to merge it with the existing stack at the dropped position.
 2. Insert it at the dropped position if the slot is empty
 3. Merge it into any stack of the same item in the inventory
 4. Insert it at the first empty slot
 
Step 3 did prevent merging into full stacks but did not check that the
combined size of the existing stack and the dropped stack does not
exceed the stack limit. Now it does.
 
Fixes: bug #1111

Comment posted on behalf of

Daniel Scharrer

Jul 11, 14:45

The issue was updated with the following change(s):

The custom field Fixed in has been updated, from Unknown to Arx Libertatis 1.2.

1b6c090

master Revision 1b6c090afccbc33a3a75bbebb743cda691c8cfc4 by

Daniel Scharrer

Mar 11, 22:30 - Preceeded by e454b25ae7297747d14f9ba3f477c28161c582ae

Show more details

Log entry

Inventory: Fix item stack size violation

When dropping an item stack into the secondary inventory (inventory of
a non-player entity) at a position we:
 1. Try to merge it with the existing stack at the dropped position.
 2. Insert it at the dropped position if the slot is empty
 3. Merge it into any stack of the same item in the inventory
 4. Insert it at the first empty slot

Step 3 did prevent merging into full stacks but did not check that the
combined size of the existing stack and the dropped stack does not
exceed the stack limit. Now it does.

Fixes: bug #1111

1b6c090

travis Revision 1b6c090afccbc33a3a75bbebb743cda691c8cfc4 by

Daniel Scharrer

Mar 11, 22:30 - Preceeded by e454b25ae7297747d14f9ba3f477c28161c582ae

Show more details

Log entry

Inventory: Fix item stack size violation

When dropping an item stack into the secondary inventory (inventory of
a non-player entity) at a position we:
 1. Try to merge it with the existing stack at the dropped position.
 2. Insert it at the dropped position if the slot is empty
 3. Merge it into any stack of the same item in the inventory
 4. Insert it at the first empty slot

Step 3 did prevent merging into full stacks but did not check that the
combined size of the existing stack and the dropped stack does not
exceed the stack limit. Now it does.

Fixes: bug #1111

* Username
* Display name
The "display name" is the name shown to others
Real name
* E-mail address
* Confirm e-mail

Welcome to The Bug Genie

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Username
Password