Welcome to The Bug Genie

Show more details Hide details

FilesystemWindows: Fix inverted directory end check

Fixes: bug #1440

Changed files

src/io/fs/FilesystemWindows.cpp

Diff

View

Affected issues

• Bug report #1440

Show more details Hide details

Inventory: Fix item stack size violation

When dropping an item stack into the secondary inventory (inventory of
a non-player entity) at a position we:
 1. Try to merge it with the existing stack at the dropped position.
 2. Insert it at the dropped position if the slot is empty
 3. Merge it into any stack of the same item in the inventory
 4. Insert it at the first empty slot

Step 3 did prevent merging into full stacks but did not check that the
combined size of the existing stack and the dropped stack does not
exceed the stack limit. Now it does.

Fixes: bug #1111

Changed files

src/game/Inventory.cpp

Diff

View

Affected issues

• Bug report #1111

Show more details Hide details

FilesystemWindows: Add retry logic to (re)moving files

Removing or renaming files can fail under Windows if another process
(for example an anti virus scanner or indexer) has the file open.

See: issue #1218

Changed files

src/io/fs/FilesystemWindows.cpp

Diff

View

Affected issues

• Bug report #1218

Show more details Hide details

Draw: Fix overzealous sprite culling

Fixes: bug #1315

Changed files

src/graphics/Draw.cpp

Diff

View

Affected issues

• Bug report #1315

Show more details Hide details

Math: Update error tolerance in angleToFrontUpVec() assert

Fixes: bug #1307

Changed files

src/graphics/Math.cpp

Diff

View

Affected issues

• Crash report #1307

Show more details Hide details

Math: Update error tolerance in angleToFrontUpVec() assert

Fixes: bug #1307

Changed files

src/graphics/Math.cpp

Diff

View

Affected issues

• Crash report #1307

Show more details Hide details

ImageSave: Rewrite BMP saving on top of fs::ofstream

Fixes: bug #1291 (save screenshots)

Changed files

	src/graphics/image/stb_image_write.h	deleted
	src/graphics/image/stb_image_write.cpp	deleted
	src/graphics/image/ImageSave.cpp	new file
	src/graphics/image/Image.cpp	Diff	View
	CMakeLists.txt	Diff	View

Affected issues

• Bug report #1291

Show more details Hide details

ImageSave: Rewrite BMP saving on top of fs::ofstream

Fixes: bug #1291 (save screenshots)

Changed files

	src/graphics/image/stb_image_write.h	deleted
	src/graphics/image/stb_image_write.cpp	deleted
	src/graphics/image/ImageSave.cpp	new file
	src/graphics/image/Image.cpp	Diff	View
	CMakeLists.txt	Diff	View

Affected issues

• Bug report #1291

Show more details Hide details

CMake: Always try to use WCHAR with fstream open on Windows

Fixes: bug #1291 (except for save screenshots)

Changed files

	CMakeLists.txt	Diff	View
	cmake/CXXVersionCheck.cmake	Diff	View

Affected issues

• Bug report #1291

Show more details Hide details

CMake: Always try to use WCHAR with fstream open on Windows

Fixes: bug #1291 (except for save screenshots)

Changed files

	CMakeLists.txt	Diff	View
	cmake/CXXVersionCheck.cmake	Diff	View

Affected issues

• Bug report #1291

Show more details Hide details

OpenGLRenderer: Add support for clearing while scissor is active

Fixes: issue #1195

Changed files

	src/graphics/opengl/OpenGLRenderer.cpp	Diff	View
	src/graphics/opengl/OpenGLRenderer.h	Diff	View

Affected issues

• Crash report #1195

Show more details Hide details

OpenGLRenderer: Add support for clearing while scissor is active

Fixes: issue #1195

Changed files

	src/graphics/opengl/OpenGLRenderer.cpp	Diff	View
	src/graphics/opengl/OpenGLRenderer.h	Diff	View

Affected issues

• Crash report #1195

Show more details Hide details

spells: Fix reveal and enchant object spells lasting forever

Fixes: issue #1268

Changed files

	src/game/magic/spells/SpellsLvl03.cpp	Diff	View
	src/game/magic/spells/SpellsLvl08.cpp	Diff	View

Affected issues

• Bug report #1268

Show more details Hide details

spells: Fix reveal and enchant object spells lasting forever

Fixes: issue #1268

Changed files

	src/game/magic/spells/SpellsLvl03.cpp	Diff	View
	src/game/magic/spells/SpellsLvl08.cpp	Diff	View

Affected issues

• Bug report #1268

Show more details Hide details

Interface: Fix trying to render and undefined note

Fixes: issue #1244

Changed files

src/gui/Interface.cpp

Diff

View

Affected issues

• Crash report #1244

Show more details Hide details

ArxGame: Always allow quickloading

Fixes: issue #1224

Changed files

src/core/ArxGame.cpp

Diff

View

Affected issues

• Bug report #1224

Show more details Hide details

Paths: Remove zone enter script event hack

The current zone of an entity is *not* stored in save files, meaning
that after loading a save zone enter script events are re-sent for
all entities already in the zone. This hack was supposed to prevent
that for two specific zones on the dwarven forge level.

The ingot_maker and mauld_user zones are used to detect ingredients
placed in the apparatus for smelting ores into metal bars or bars into
items respectively. When an appropriate entity enters these zones
the ID is stored in variables on the controlling lever entity to decide
if enough ingredients are present, which output entity to produce and
which input entities to destroy. These variables are only changed if
they are not already set to an entity so re-running the zone enter
events for entities already in the zone should have no effect.

Further, the current zone is updated for at most  10 to 50 entities,
varying depending on framerate. This especially means that there is no
guarantee that any given entity will have its zone updated in the first
frame after loading and thus suppressed by this hack.

Thus the hack to suppress these script events for the two zones is not
only not needed with the Arx Fatalis 1.21 scripts but also ineffective.

Fixes: issue #505

Changed files

src/ai/Paths.cpp

Diff

View

Affected issues

• Crash report #505

Show more details Hide details

Scene: Animate water and lava while the night vision spell is active

Fixes: issue #1053

Changed files

src/scene/Scene.cpp

Diff

View

Affected issues

• Bug report #1053

Show more details Hide details

NPC: Hide flare for dragged torches that aren't visible

Fixes: issue #783

Changed files

src/game/NPC.cpp

Diff

View

Affected issues

• Bug report #783

Show more details Hide details

Cursor: Fix dragged entity rotation

Fixes: issue #591

Changed files

src/gui/Cursor.cpp

Diff

View

Affected issues

• Bug report #591

Show more details Hide details

ArxGame: Don't draw light flares in front of the interface

Fixes: issue #1145

Changed files

src/core/ArxGame.cpp

Diff

View

Affected issues

• Bug report #1145

Show more details Hide details

Light: Include falloff distance when culling dynamic lights

Fixes: issue #1213

Changed files

src/scene/Light.cpp

Diff

View

Affected issues

• Bug report #1213

Show more details Hide details

TextInputWidget: Use a TextInputHandler

This enables unicode save names and fixes problems when the quickload
action was bound to a text input key.

Implements: enhancement #1032

Changed files

	src/gui/widget/TextInputWidget.cpp	Diff	View
	src/gui/widget/TextInputWidget.h	Diff	View

Affected issues

• Enhancement #1032

Show more details Hide details

Book: Use isCleared() member function to know when to reload quest book entries
Fixes: Issue #1021

Changed files

src/gui/book/Book.cpp

Diff

View

Affected issues

• Bug report #1021

Show more details Hide details

Input: Ignore mouse buttons in action bindings in the main menu

Otherwise the player can lock themselves out of the config menu by
binding the 'toggle fullscreen' or 'quick load' actions to the left
mouse button.

Fixes: issue #1136

Changed files

src/input/Input.cpp

Diff

View

Affected issues

• Bug report #1136

Show more details Hide details

ChangeLevel: Fix loading of camera entity properties

Fixes: issue #1135

Changed files

src/scene/ChangeLevel.cpp

Diff

View

Affected issues

• Bug report #1135

Show more details Hide details

ScriptedConversation: Support peak() for the speak command

This fixes combine highlighting for weapons, which will always have
a speak command if they are already enchanted.

Fixes: issue #1130

Changed files

	src/script/Script.h	Diff	View
	src/script/ScriptedConversation.cpp	Diff	View

Affected issues

• Bug report #1130

Show more details Hide details

SpellsLvl05: Properly end the trap spell

Fixes: issue #1132

Changed files

src/game/magic/spells/SpellsLvl05.cpp

Diff

View

Affected issues

• Bug report #1132

Show more details Hide details

Equipment: Make durability decrease framerate independent

This particular durabilty decrease is executed for each frame of the
strike where the weapon is colliding with something.

Fixes: issue #790

Changed files

src/game/Equipment.cpp

Diff

View

Affected issues

• Bug report #790

Show more details Hide details

ScriptUtils: Ignore select newlines in broken scripts

This fixes missing black bars in a cutscene in the castle of arx as
well as a bugged tentacle in the Ylside bunker.

Note: Arx Fatalis 1.21 ignores all newlines here, but there is also
one case of an unexpected newline because the command is missing
a parameter.

Fixes: issue #1014

Changed files

src/script/ScriptUtils.cpp

Diff

View

Affected issues

• Bug report #1014

Show more details Hide details

SaveFormat: Fix precast spells having 0 duration after level change

Fixes: issue #1124

Changed files

src/scene/SaveFormat.h

Diff

View

Affected issues

• Bug report #1124

Show more details Hide details

MeshManipulation: Fix texture replacement matching rules

This was broken in commit 3d3ec1f which changed the behavior to only
match against the untweaked texture name. Some scripts supply the
current tweaked texture name instead.

Fixes: issue #1112

Changed files

src/graphics/data/MeshManipulation.cpp

Diff

View

Affected issues

• Bug report #1112

Show more details Hide details

Book: Remove duplicated page turn sound when clicking top tabs

Fixes: issue #1125

Changed files

src/gui/book/Book.cpp

Diff

View

Affected issues

• Bug report #1125

Show more details Hide details

Interface: Replace combine prediction with non-destructive execution

Fixes: issue #121

Changed files

src/gui/Interface.cpp

Diff

View

Affected issues

• Bug report #121

Show more details Hide details

Work around MSVC 2013 compiler bug causing cinematics to crash

Fixes: issue #1097

Changed files

src/cinematic/CinematicKeyframer.cpp

Diff

View

Affected issues

• Crash report #1097

Show more details Hide details

MainMenu: Re-add gamma option

This partially reverts commit 3ad44dc.

Implements: feature request #254

Changed files

src/gui/MainMenu.cpp

Diff

View

Affected issues

• Feature request #254

Show more details Hide details

MainMenu: Re-add gamma option

This partially reverts commit 3ad44dc.

Implements: feature request #254

Changed files

src/gui/MainMenu.cpp

Diff

View

Affected issues

• Feature request #254

Show more details Hide details

Config: Re-add gamma option

Gamma is only changed while fullscreen.

This partially reverts commit 3ad44dc.

Implements: feature request #254

Changed files

	src/gui/MenuPublic.h	Diff	View
	src/gui/MenuPublic.cpp	Diff	View
	src/core/Config.h	Diff	View
	src/core/Config.cpp	Diff	View
	src/core/ArxGame.cpp	Diff	View

Affected issues

• Feature request #254

Show more details Hide details

Config: Re-add gamma option

Gamma is only changed while fullscreen.

This partially reverts commit 3ad44dc.

Implements: feature request #254

Changed files

	src/gui/MenuPublic.h	Diff	View
	src/gui/MenuPublic.cpp	Diff	View
	src/core/Config.h	Diff	View
	src/core/Config.cpp	Diff	View
	src/core/ArxGame.cpp	Diff	View

Affected issues

• Feature request #254

Show more details Hide details

ArxGame: Implement quick level transitions

Level transitions can be configured to either happen immediately or to
be activated using the jump key binding.

Implements: feature request #105

Changed files

	src/core/Config.h	Diff	View
	src/core/Config.cpp	Diff	View
	src/core/ArxGame.cpp	Diff	View

Affected issues

• Feature request #105