Arx Libertatis Bug Tracker
Arx Libertatis (arx)
c60e1d1
master Revision c60e1d1ddb60059410b11848b216eab417548d22 by
 Daniel Scharrer
Oct 22, 18:55 - Preceeded by d9cf8dcdbd4d80fdf427cc37bb4d7552f5382b81
Log entry
ScriptedPlayer: Adjust open bag in HUD when destroying bags

Fixes a crash when using the `ridiculous` script command when bag 2
or higher is open in the HUD.

Fixes: issue #1723
711c68e
master Revision 711c68ea2b6b8d617fd1641cb1ba8e98bc86cc28 by
 Daniel Scharrer
Jun 18, 16:29 - Preceeded by bd894de2c762b3a4dfab2891ed5bb92eebb6e3ff
Log entry
Scene: Add additional sanity checks

Perhaps this will help track down the room issue.

See: issue #1667
bd894de
master Revision bd894de2c762b3a4dfab2891ed5bb92eebb6e3ff by
 Daniel Scharrer
Jun 18, 15:28 - Preceeded by f1f01cf027adc165e4b9066f1fd2d878a2aad197
Log entry
ScriptedPlayer: Put contents in front of the player when destroying bags

Fixes a crash when using the `ridiculous` script command with items
in bags 2 or higher.

Fixes: issue #1680
8b71c58
master Revision 8b71c584e953f2d0fb98173b30c9572d41391b34 by
 Daniel Scharrer
Jun 18, 14:58 - Preceeded by 95618208d2cfce2c9b2442382eddb1e474d807ba
Log entry
Interactive: Always unequip NPC weapons on entity destruction

This fixes a dangling owner reference when the owner of a non-linked
weapon is deleted.

Fixes: issue #1673
6857102
master Revision 68571029637157ce0369d69a9447187137367d0a by
 Daniel Scharrer
Jan 06, 22:50 - Preceeded by c4930313bb65e8d7190728382bf793c5b675cf63
Log entry
Raycast: Handle edge cases in start tile bounds adjustment

Was broken in commit d8133eb.

Fixes: issue #1671
c66367b
master Revision c66367b5a1874794ac0699e55463b1c0c8181301 by
 Daniel Scharrer
Jan 05, 20:31 - Preceeded by 6a970e07983d47d3b4a4fdea6431d99c03aefff0
Log entry
Mesh: Check face room index bounds when loading scenes

See: issue #1667
6a970e0
master Revision 6a970e07983d47d3b4a4fdea6431d99c03aefff0 by
 Daniel Scharrer
Jan 05, 20:29 - Preceeded by 66d585212af0c6fa8d07612d09ddb22ae37953c4
Log entry
ChangeLevel: Fix out of bounds access to NPC extra_rotate data in saves

This affects both reading and writing saves so could corrupt both the
rotation angles as well as the first stacked target. The write also
touches the saved blood color but that is overwritten with the correct
value later.

Only affects NPCs with extra rotation data - i.e. those that hat the
look around (-l) or stare at (-a) behaviors active at some point.

Was broken in commit 239cff7.

Fixes: issue #1668
a801b7d
master Revision a801b7deacd170127b9a1fb4ae82bea99c420cb6 by
 Daniel Scharrer
Jan 04, 12:17 - Preceeded by 06deb7bdfbc7ef1cf666fa26901347c9c6368f1a
Log entry
LinkedObject: Fix out of bounds vector access

Fixes: issue #1664
b85cece
master Revision b85ceceae92f22f9d72acd5020eccb0393ddf0d9 by
 Daniel Scharrer
Dec 31, 21:20 - Preceeded by d05755089c91f6c9f838787a3b9658e401f92b8c
Log entry
Equipment: Handling missing object for weapons

Fixes: issue #1286
f933b8f
master Revision f933b8f7afd47529e3ad6bea7b8142139d7faaba by
 Daniel Scharrer
Dec 22, 11:04 - Preceeded by e20a61ab25a53ee11a2ef29d11ab457720c8b977
Log entry
ChangeLevel: Ingore inventory show flag in save files

Only set it if the entity is actually in an inventory.

Fixes: issue #1618
1ece2ae
master Revision 1ece2ae9dbf0f353e240f27b89177cc1dd4df10a by
 Daniel Scharrer
Jul 08, 19:11 - Preceeded by 5028ce9700ac1e087bd897e3f96812d005ecc93f
Log entry
Dragging: Fix a crash when dragging an entity without a 3D object

Fixes: issue #1592
a27febe
master Revision a27febeef7279f336bb5d3d2aeb0b492f928772d by
 Daniel Scharrer
Jul 08, 19:11 - Preceeded by 777752db45cb4245dda43bbd2d6a62377a058f5c
Log entry
Entity: Fix dangling reference in player.torch

Fixes: issue #1622
09e2c6e
1.2-branch Revision 09e2c6e1d086e2872d2c667f850970e4a84eff97 by
 Daniel Scharrer
Apr 10, 09:35 - Preceeded by 5be178eddd328b535bb91306a9ca57a94ec4044b
Log entry
Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011
(cherry picked from commit 0b5a9622629a2c80eaa31de3710e5c6dbbfa7f08)
996f448
1.2-branch Revision 996f4487fe48de55a08659f6fca26a7a91609b8d by
 Daniel Scharrer
Apr 10, 08:59 - Preceeded by 2a72695027a66265431d0e1828d4e0057b2cb377
Log entry
Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011
0b5a962
master Revision 0b5a9622629a2c80eaa31de3710e5c6dbbfa7f08 by
 Daniel Scharrer
Apr 10, 08:35 - Preceeded by a5f419a055d62319f1a36c95e8239aee8f79aeed
Log entry
Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011
8bdfb46
master Revision 8bdfb46591219e65ba4f5f80513b8c7bbe9614b8 by
 Daniel Scharrer
Apr 09, 20:41 - Preceeded by efe60583c1ce954bb7f28515ba41bb68b678db0b
Log entry
ScriptUtils: Fix converting arguments trailing junk to float

Was broken in commit 485cbf8. The old atof() version parses however much
it can while the boost::lexical_cast version defaults to 0.f if ti can't
parse the entire string. Revert to the old behavior but faster.

Fixes: issue #1616
1e993c0
master Revision 1e993c0abab73306aa369b231927534a0a3e56a3 by
 Daniel Scharrer
Apr 07, 17:49 - Preceeded by eb92e5485d5fb632da950145d51be221fba6b436
Log entry
Mesh: Fix bogus portal range check

Fixes: issue #1615
d86bb8a
1.2-branch Revision d86bb8a7e4277b6350553a594b4813aa78cce552 by
 Daniel Scharrer
Apr 02, 19:51 - Preceeded by 7c2a8a603800e526229faf54395a6beb73f91b03
Log entry
CMake: Don't use __builtin_unreachable() with GCC 9.0-9.4 and 10.0-10.3

These compilers are known to miscompile the save loading code due to
a bug in the variable range information gained from these hints.
This bug was fixed in GCC 11 and has now been backported to the 9 and
10 branches.

See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97953
Fixes: issue #1600
(cherry picked from commit c134113478ac30a030b9e62aafba59bd08ca380f)
7c2a8a6
1.2-branch Revision 7c2a8a603800e526229faf54395a6beb73f91b03 by
 Daniel Scharrer
Apr 02, 16:16 - Preceeded by b37d0398e7f05e410c4c678490df82eba27c90f6
Log entry
DrawDebug: Fix a crash with linked objects without an entity

Fixes: issue #1608
(cherry picked from commit bde1b96d28be8de7b345b378abb9de276f61c578)
bde1b96
master Revision bde1b96d28be8de7b345b378abb9de276f61c578 by
 Daniel Scharrer
Apr 02, 16:14 - Preceeded by 77c9aed70edf6da64c537cb33681995e49bdc272
Log entry
DrawDebug: Fix a crash with linked objects without an entity

Fixes: issue #1608
b479d81
1.2-branch Revision b479d81c1fadb583e56d48852c4dc59ed9ad7329 by
 Daniel Scharrer
Apr 02, 14:58 - Preceeded by 332562fd525d1aa51d7e136f6557ee200de8c553
Log entry
Damage: Don't end speech on death

In Arx Fatalis 1.21. ARX_SPEECH_ReleaseIOSpeech did not work correctly.
This was fixed in commit aac2d8c for Arx Libertatis 1.0.3 because it
left dangling references after entity destruction.

However, ARX_SPEECH_ReleaseIOSpeech also got called on NPC death where
that fix meant that the death scream no longer gets played. Fix that.

Fixes: issue #1579
(cherry picked from commit f24f6f6d46841ee1aa8ab083f5483b8cfb338ca7)
332562f
1.2-branch Revision 332562fd525d1aa51d7e136f6557ee200de8c553 by
 Daniel Scharrer
Apr 02, 14:49 - Preceeded by c33feb2a8dea8fab2de04c9bf3c1aa920d2dd730
Log entry
ArxGame: Disable color keying for particles that don't need it

Fixes: issue #1595 (for fog, fire smoke, water and lava)
(cherry picked from commit 71a9bf976ab678a0a17a6722f35f6b6f1f892290)
0313c51
master Revision 0313c51625f3f55016cdad43d2c7f7296d27949c by
 Daniel Scharrer
Jan 14, 15:01 - Preceeded by daa77730b083070fc93912d0aa6cdde005007ba7
Log entry
ScriptedNPC: Add workaround for broken ratman backflip in intro

Fixes: issue #93
2d69e48
master Revision 2d69e487568d891bd4b51ed64635af7fc62ba565 by
 Daniel Scharrer
Jan 14, 13:31 - Preceeded by 21aabf99b570d07cd647f01c21ad4697df3447e1
Log entry
OpenGLUtil: Extend GL_ARB_sample_shading blacklist to Intel Iris Xe GPUs

Fixes: issue #1603
f24f6f6
master Revision f24f6f6d46841ee1aa8ab083f5483b8cfb338ca7 by
 Daniel Scharrer
Jan 14, 02:12 - Preceeded by 1a99607275b4bb79b50810605eb457797fc5dca8
Log entry
Damage: Don't end speech on death

In Arx Fatalis 1.21. ARX_SPEECH_ReleaseIOSpeech did not work correctly.
This was fixed in commit aac2d8c for Arx Libertatis 1.0.3 because it
left dangling references after entity destruction.

However, ARX_SPEECH_ReleaseIOSpeech also got called on NPC death where
that fix meant that the death scream no longer gets played. Fix that.

Fixes: issue #1579
3783065
master Revision 378306569cf2b4b7c1cf8206feec460f567ee0b6 by
 Daniel Scharrer
Jan 13, 04:14 - Preceeded by 2c3616f4c8cd3b42d6bab2bf5e9e2bae03f0ef9f
Log entry
arx-install-data: Add GOG 1.22 installer names to search

See: issue #1589
c134113
master Revision c134113478ac30a030b9e62aafba59bd08ca380f by
 Daniel Scharrer
Jan 12, 20:35 - Preceeded by 28afdd43111319d0c85f62734877e250b1a14a95
Log entry
CMake: Don't use __builtin_unreachable() with GCC 9.0-9.4 and 10.0-10.3

These compilers are known to miscompile the save loading code due to
a bug in the variable range information gained from these hints.
This bug was fixed in GCC 11 and has now been backported to the 9 and
10 branches.

See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97953
Fixes: issue #1600
3aa6c0d
master Revision 3aa6c0d1ddd614fbd0e48b679498dba1b5bf7e0d by
 Daniel Scharrer
Jan 12, 20:35 - Preceeded by adc3ab321bd4ea7b4cefbe84ce982023e4ef6af5
Log entry
OpenGLRenderer: Don't use per-sample color key test + additive blending

Instead modulate the blend factor with alpha.

Fixes: issue #1595 (general case)
71a9bf9
master Revision 71a9bf976ab678a0a17a6722f35f6b6f1f892290 by
 Daniel Scharrer
Jan 12, 20:35 - Preceeded by 65a871e47fc89335f0b4a0675be2761e0d5d02de
Log entry
ArxGame: Disable color keying for particles that don't need it

Fixes: issue #1595 (for fog, fire smoke, water and lava)
76389ba
master Revision 76389ba42699023c6f64a669ddac900342a1b05e by
 Daniel Scharrer
Jan 08, 20:09 - Preceeded by effd6a789b5683aeced04c56697b62d43c830bb7
Log entry
Script: Add the ^visible* system variable

Implements: issue #1593 (partial)
133099a
master Revision 133099ab4e2b72173a7396e2c58505533ac0b643 by
 Guest user
Nov 30, 19:35 - Preceeded by d35368cae610b4edeec61cd41e4d2367a4d33f58
Log entry
Fix #117: compilation warning with gcc 6.3.0

Fix the following warning:
```
/arrow/cpp/src/arrow/vendored/fast_float/digit_comparison.h:62:50: error: right shift count >= width of type [-Werror=shift-count-overflow]
       am.power2 = int32_t((bits & exponent_mask) >> binary_format::mantissa_explicit_bits());
                           ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
da554e0
1.2-branch Revision da554e0f3fcad4dbbe7c83a55b074ff73b7cc8b6 by
 Daniel Scharrer
Aug 29, 11:43 - Preceeded by a3b7e3d5df1b47f2f7a344b8f01bd8229febd755
Log entry
Interactive: Don't try to activate physics for incomplete objects

Fixes: issue #1259
(cherry picked from commit 7536846851b5682b78c4168a1098b3aad3fe214a)
7536846
master Revision 7536846851b5682b78c4168a1098b3aad3fe214a by
 Daniel Scharrer
Aug 29, 11:40 - Preceeded by a839fc2a9444560a5c895381480109a9d6abc818
Log entry
Interactive: Don't try to activate physics for incomplete objects

Fixes: issue #1259
1f94c55
1.2-branch Revision 1f94c550a92a12b81d731dc7a013a041c9919437 by
 Daniel Scharrer
Aug 23, 22:16 - Preceeded by 2d617ef4cdb5f630a8e77b300262c8d3137c479c
Log entry
Collisions: Fix null pointer dereference with the flying eye spell

Fixes: issue #511
(cherry picked from commit 4940f8430b7e7390fc8daaec2688ac865c15123c)
4940f84
master Revision 4940f8430b7e7390fc8daaec2688ac865c15123c by
 Daniel Scharrer
Aug 23, 22:11 - Preceeded by 15662f289a7005e148b81a438aad5ab45e375a09
Log entry
Collisions: Fix null pointer dereference with the flying eye spell

Fixes: issue #511
3e74ed3
master Revision 3e74ed313a1377f854ab7c6a832d34c612a07940 by
 Guest user
Aug 21, 18:07 - Preceeded by fe1ce5805331d9edae6fe71f10e0b38c3ac4bbe7
Log entry
Fixes #94, with unspecified behavior in pointer comparisons.
2d617ef
1.2-branch Revision 2d617ef4cdb5f630a8e77b300262c8d3137c479c by
 Daniel Scharrer
Aug 19, 21:57 - Preceeded by 1183c70d3d6e5540e178e8a43e4aea82d38bb5f6
Log entry
MenuWidgets: Fix crash when releasing escape in the first menu frame

Fixes: issue #1155
(cherry picked from commit f06f4263c5251e08e65c6d57a12f0b3a2e7a8781)
f06f426
master Revision f06f4263c5251e08e65c6d57a12f0b3a2e7a8781 by
 Daniel Scharrer
Aug 19, 20:59 - Preceeded by 67f8b9b345ec81a626a2ff2885f5239f649ef387
Log entry
MenuWidgets: Fix crash when releasing escape in the first menu frame

Fixes: issue #1155
034aa03
1.2-branch Revision 034aa03a556b7287da4648f44459d94b32a851ac by
 Daniel Scharrer
Aug 12, 22:10 - Preceeded by f89d44baa388812e7a2bd0373357669a67291b42
Log entry
Inventory: Fix assert failure

The show flag sanity check in Inventory::remove() failed when trying to
give an item to the player which is in another entity's inventory
but the player's inventory is full.

Fixes: issue #1570
(cherry picked from commit 0b414fac0dceec6f9d6e22a834fda925f4fbf2fa)
f89d44b
1.2-branch Revision f89d44baa388812e7a2bd0373357669a67291b42 by
 Daniel Scharrer
Aug 12, 22:10 - Preceeded by ce53cb5060fe366692e6936365c8f02fbdf57c28
Log entry
Texture: Don't try to apply color key if image failed to load

Fixes: issue #1557
(cherry picked from commit e5ba607d91f03bd6e87dc8eda9a5147a4cbc7726)