Welcome to The Bug Genie

Show more details Hide details

Raycast: Handle edge cases in start tile bounds adjustment

Was broken in commit d8133eb.

Fixes: issue #1671

Changed files

src/graphics/Raycast.cpp

Diff

View

Affected issues

• Crash report #1671

Show more details Hide details

Mesh: Check face room index bounds when loading scenes

See: issue #1667

Changed files

src/graphics/data/Mesh.cpp

Diff

View

Affected issues

• Crash report #1667

Show more details Hide details

ChangeLevel: Fix out of bounds access to NPC extra_rotate data in saves

This affects both reading and writing saves so could corrupt both the
rotation angles as well as the first stacked target. The write also
touches the saved blood color but that is overwritten with the correct
value later.

Only affects NPCs with extra rotation data - i.e. those that hat the
look around (-l) or stare at (-a) behaviors active at some point.

Was broken in commit 239cff7.

Fixes: issue #1668

Changed files

	src/scene/SaveFormat.h	Diff	View
	src/scene/ChangeLevel.cpp	Diff	View

Affected issues

• Crash report #1668

Show more details Hide details

LinkedObject: Fix out of bounds vector access

Fixes: issue #1664

Changed files

src/scene/LinkedObject.cpp

Diff

View

Affected issues

• Crash report #1664

Show more details Hide details

Equipment: Handling missing object for weapons

Fixes: issue #1286

Changed files

	src/game/Equipment.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1286

Show more details Hide details

ChangeLevel: Ingore inventory show flag in save files

Only set it if the entity is actually in an inventory.

Fixes: issue #1618

Changed files

	src/scene/ChangeLevel.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1618

Show more details Hide details

Dragging: Fix a crash when dragging an entity without a 3D object

Fixes: issue #1592

Changed files

	src/gui/Dragging.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1592

Show more details Hide details

Entity: Fix dangling reference in player.torch

Fixes: issue #1622

Changed files

	src/game/Entity.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1622

Show more details Hide details

Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011
(cherry picked from commit 0b5a9622629a2c80eaa31de3710e5c6dbbfa7f08)

Changed files

	src/gui/Dragging.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Bug report #1011

Show more details Hide details

Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011

Changed files

	src/gui/Dragging.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Bug report #1011

Show more details Hide details

Dragging: Don't allow using non-interactive items by dropping them

Was broken in commit f704006.

Fixes: issue #1011

Changed files

	src/gui/Dragging.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Bug report #1011

Show more details Hide details

ScriptUtils: Fix converting arguments trailing junk to float

Was broken in commit 485cbf8. The old atof() version parses however much
it can while the boost::lexical_cast version defaults to 0.f if ti can't
parse the entire string. Revert to the old behavior but faster.

Fixes: issue #1616

Changed files

src/script/ScriptUtils.cpp

Diff

View

Affected issues

• Bug report #1616

Show more details Hide details

Mesh: Fix bogus portal range check

Fixes: issue #1615

Changed files

src/graphics/data/Mesh.cpp

Diff

View

Affected issues

• Bug report #1615

Show more details Hide details

CMake: Don't use __builtin_unreachable() with GCC 9.0-9.4 and 10.0-10.3

These compilers are known to miscompile the save loading code due to
a bug in the variable range information gained from these hints.
This bug was fixed in GCC 11 and has now been backported to the 9 and
10 branches.

See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97953
Fixes: issue #1600
(cherry picked from commit c134113478ac30a030b9e62aafba59bd08ca380f)

Changed files

CMakeLists.txt

Diff

View

Affected issues

• Crash report #1600

Show more details Hide details

DrawDebug: Fix a crash with linked objects without an entity

Fixes: issue #1608
(cherry picked from commit bde1b96d28be8de7b345b378abb9de276f61c578)

Changed files

	src/graphics/DrawDebug.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1608

Show more details Hide details

DrawDebug: Fix a crash with linked objects without an entity

Fixes: issue #1608

Changed files

	src/graphics/DrawDebug.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Crash report #1608

Show more details Hide details

Damage: Don't end speech on death

In Arx Fatalis 1.21. ARX_SPEECH_ReleaseIOSpeech did not work correctly.
This was fixed in commit aac2d8c for Arx Libertatis 1.0.3 because it
left dangling references after entity destruction.

However, ARX_SPEECH_ReleaseIOSpeech also got called on NPC death where
that fix meant that the death scream no longer gets played. Fix that.

Fixes: issue #1579
(cherry picked from commit f24f6f6d46841ee1aa8ab083f5483b8cfb338ca7)

Changed files

	src/scene/Interactive.cpp	Diff	View
	src/game/Entity.cpp	Diff	View
	src/game/Damage.cpp	Diff	View

Affected issues

• Bug report #1579

Show more details Hide details

ArxGame: Disable color keying for particles that don't need it

Fixes: issue #1595 (for fog, fire smoke, water and lava)
(cherry picked from commit 71a9bf976ab678a0a17a6722f35f6b6f1f892290)

Changed files

src/core/ArxGame.cpp

Diff

View

Affected issues

• Bug report #1595

Show more details Hide details

ScriptedNPC: Add workaround for broken ratman backflip in intro

Fixes: issue #93

Changed files

	src/script/ScriptedNPC.cpp	Diff	View
	src/graphics/effects/Lightning.cpp	Diff	View
	src/game/magic/Spell.h	Diff	View

Affected issues

• Bug report #93

Show more details Hide details

OpenGLUtil: Extend GL_ARB_sample_shading blacklist to Intel Iris Xe GPUs

Fixes: issue #1603

Changed files

src/graphics/opengl/OpenGLUtil.cpp

Diff

View

Affected issues

• Bug report #1603

Show more details Hide details

Damage: Don't end speech on death

In Arx Fatalis 1.21. ARX_SPEECH_ReleaseIOSpeech did not work correctly.
This was fixed in commit aac2d8c for Arx Libertatis 1.0.3 because it
left dangling references after entity destruction.

However, ARX_SPEECH_ReleaseIOSpeech also got called on NPC death where
that fix meant that the death scream no longer gets played. Fix that.

Fixes: issue #1579

Changed files

	src/scene/Interactive.cpp	Diff	View
	src/game/Entity.cpp	Diff	View
	src/game/Damage.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Bug report #1579

Show more details Hide details

arx-install-data: Add GOG 1.22 installer names to search

See: issue #1589

Changed files

scripts/arx-install-data

Diff

View

Affected issues

• Enhancement #1589

Show more details Hide details

OpenGLRenderer: Don't use per-sample color key test + additive blending

Instead modulate the blend factor with alpha.

Fixes: issue #1595 (general case)

Changed files

src/graphics/opengl/OpenGLRenderer.cpp

Diff

View

Affected issues

• Bug report #1595

Show more details Hide details

CMake: Don't use __builtin_unreachable() with GCC 9.0-9.4 and 10.0-10.3

These compilers are known to miscompile the save loading code due to
a bug in the variable range information gained from these hints.
This bug was fixed in GCC 11 and has now been backported to the 9 and
10 branches.

See: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97953
Fixes: issue #1600

Changed files

CMakeLists.txt

Diff

View

Affected issues

• Crash report #1600

Show more details Hide details

ArxGame: Disable color keying for particles that don't need it

Fixes: issue #1595 (for fog, fire smoke, water and lava)

Changed files

	src/core/ArxGame.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Bug report #1595

Show more details Hide details

Script: Add the ^visible* system variable

Implements: issue #1593 (partial)

Changed files

	src/script/Script.cpp	Diff	View
	CHANGELOG	Diff	View

Affected issues

• Enhancement #1593

Show more details Hide details

Fix #117: compilation warning with gcc 6.3.0

Fix the following warning:
```
/arrow/cpp/src/arrow/vendored/fast_float/digit_comparison.h:62:50: error: right shift count >= width of type [-Werror=shift-count-overflow]
       am.power2 = int32_t((bits & exponent_mask) >> binary_format::mantissa_explicit_bits());
                           ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Changed files

	include/fast_float/float_common.h	Diff	View
	include/fast_float/digit_comparison.h	Diff	View

Affected issues

• Feature request #117

Show more details Hide details

Interactive: Don't try to activate physics for incomplete objects

Fixes: issue #1259
(cherry picked from commit 7536846851b5682b78c4168a1098b3aad3fe214a)

Changed files

src/scene/Interactive.cpp

Diff

View

Affected issues

• Crash report #1259

Show more details Hide details

Interactive: Don't try to activate physics for incomplete objects

Fixes: issue #1259

Changed files

src/scene/Interactive.cpp

Diff

View

Affected issues

• Crash report #1259

Show more details Hide details

Collisions: Fix null pointer dereference with the flying eye spell

Fixes: issue #511
(cherry picked from commit 4940f8430b7e7390fc8daaec2688ac865c15123c)

Changed files

src/physics/Collisions.cpp

Diff

View

Affected issues

• Crash report #511

Show more details Hide details

Collisions: Fix null pointer dereference with the flying eye spell

Fixes: issue #511

Changed files

src/physics/Collisions.cpp

Diff

View

Affected issues

• Crash report #511

Show more details Hide details

Fixes #94, with unspecified behavior in pointer comparisons.

Changed files

include/fast_float/ascii_number.h

Diff

View

Affected issues

• Bug report #94

Show more details Hide details

MenuWidgets: Fix crash when releasing escape in the first menu frame

Fixes: issue #1155
(cherry picked from commit f06f4263c5251e08e65c6d57a12f0b3a2e7a8781)

Changed files

src/gui/MenuWidgets.cpp

Diff

View

Affected issues

• Crash report #1155

Show more details Hide details

MenuWidgets: Fix crash when releasing escape in the first menu frame

Fixes: issue #1155

Changed files

src/gui/MenuWidgets.cpp

Diff

View

Affected issues

• Crash report #1155

Show more details Hide details

Inventory: Fix assert failure

The show flag sanity check in Inventory::remove() failed when trying to
give an item to the player which is in another entity's inventory
but the player's inventory is full.

Fixes: issue #1570
(cherry picked from commit 0b414fac0dceec6f9d6e22a834fda925f4fbf2fa)

Changed files

src/game/Inventory.cpp

Diff

View

Affected issues

• Crash report #1570

Show more details Hide details

Texture: Don't try to apply color key if image failed to load

Fixes: issue #1557
(cherry picked from commit e5ba607d91f03bd6e87dc8eda9a5147a4cbc7726)

Changed files

src/graphics/texture/Texture.cpp

Diff

View

Affected issues

• Crash report #1557

Show more details Hide details

OpenGLUtil: Extend Intel GL_ARB_sample_shading blacklist

Relax render string match to cover all "Intel(R) HD Graphics" devices
with driver version 10.18.10.*.

Fixes: issue #1568 (hopefully)
(cherry picked from commit 76969902fd05a169402308428e0b69f85fbe7ac2)

Changed files

src/graphics/opengl/OpenGLUtil.cpp

Diff

View

Affected issues

• Crash report #1568

Show more details Hide details

Inventory: Fix assert failure

The show flag sanity check in Inventory::remove() failed when trying to
give an item to the player which is in another entity's inventory
but the player's inventory is full.

Fixes: issue #1570

Changed files

src/game/Inventory.cpp

Diff

View

Affected issues

• Crash report #1570

Show more details Hide details

Texture: Don't try to apply color key if image failed to load

Fixes: issue #1557

Changed files

src/graphics/texture/Texture.cpp

Diff

View

Affected issues

• Crash report #1557

Show more details Hide details

OpenGLUtil: Extend Intel GL_ARB_sample_shading blacklist

Relax render string match to cover all "Intel(R) HD Graphics" devices
with driver version 10.18.10.*.

Fixes: issue #1568 (hopefully)

Changed files

src/graphics/opengl/OpenGLUtil.cpp

Diff

View

Affected issues

• Crash report #1568