Arx Libertatis Bug Tracker
Please log in to bookmark issues
CLOSED  Bug report #598  -  Wrong date and time of new saves of the game after v1.1.2
Posted Dec 23, 2013 - updated Jul 14, 2015   Shortlink:
icon_info.png This issue has been closed with status "Fixed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Bug report
  • Status
  • Assigned to
    Not assigned to anyone
  • Progress
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
  • Owned by
    Not owned by anyone
  • Estimated time
    Not estimated
  • Time spent
    73 weeks, 5 days, 1 hour
  • Category
    Not determined
  • Resolution
  • Priority
  • Reproducability
    Not determined
  • Severity
    Not determined
  • Targetted for
    icon_milestones.png Not determined
  • OS
    icon_customdatatype.png Windows
  • Architecture
    icon_customdatatype.png Not determined
  • Fixed in
    icon_customdatatype.png Not determined
Issue description
After version 1.1.2 in the last builds of branch "master" new saves of the game receive date and time of loaded save, instead current system time.
Out of the three quick save works only one.
Steps to reproduce this issue
Load old save game, then make a new one, or quick save, or rewrite old save.

Comment posted by
Feb 13, 04:05
I can not reproduce this. I loaded a save and saved it again to a new slot, the time was correct.
Comment posted by
Feb 13, 09:48
Maybe this bug only on Windows.
Comment posted by
 Daniel Scharrer
Feb 24, 08:40
I also cannot reproduce this, even in my Windows 7 VM.
Comment posted by
Feb 24, 17:52
My OS is Win XP Pro SP3 Rus. ArxLibertatis/master + ArxWindows/master + CMAKE GUI 3.0.2 + Visual Studio 2010 SP1 (Russian).
Comment posted by
 Daniel Scharrer
Mar 01, 05:40
This happens because we never close the file handle of the 'current' save file and windows only guarantees to update the file modification time after closing the last write file handle. On Windows (and on Windows only) the file time is then copied along when copying the 'current' save file to the save slot.

Short term solutions:

  1. Manually set the modification of the save slot file after copying.
  2. Store the time in the save file. We don't want to change the save file format at this point, but could use some of the (currently zeroed-out) padding the in pld struct. We'd still need to do (1.) for backwards compatibility though, as well as use the file time when the new pld field is zero.

Long term solution:

Comment posted by
 Daniel Scharrer
Aug 06, 12:04
Crash report 628 - [DE2A632C] arx.exe!MenuCursor::DrawOneCursor() [menuwidgets.cpp:4931] could also be related to this (see logs).
Comment posted by
 Daniel Scharrer
Apr 28, 14:27
Could be related:
Comment posted by
 Daniel Scharrer
Jul 14, 04:41
This should be fixed in the latest development snapshot (1.2-dev-2015-07-14), please test.
Comment posted by
Jul 14, 21:04
Tested Windows 7 x64, 14/7/15 snapshot- issue is fixed with both quicksaves and normal saves. Thanks!