Arx Libertatis Bug Tracker ~ [CLOSED] #598 - Wrong date and time of new saves of the game after v1.1.2

#2

Comment posted on behalf of

Eli2

Feb 13, 03:58

The issue was updated with the following change(s):

The status has been updated, from New to Investigating.
The assignee has been changed to Eli2.

#3

Reply

Comment posted by

Eli2

Feb 13, 04:05

I can not reproduce this. I loaded a save and saved it again to a new slot, the time was correct.

#4

Reply

Comment posted by

Dimoks

Feb 13, 09:48

Maybe this bug only on Windows.

#5

Reply

Comment posted by

Daniel Scharrer

Feb 24, 08:40

I also cannot reproduce this, even in my Windows 7 VM.

#6

Reply

Comment posted by

Dimoks

Feb 24, 17:52

My OS is Win XP Pro SP3 Rus. ArxLibertatis/master + ArxWindows/master + CMAKE GUI 3.0.2 + Visual Studio 2010 SP1 (Russian).

#8

Reply

Comment posted by

Daniel Scharrer

Mar 01, 05:40

This happens because we never close the file handle of the 'current' save file and windows only guarantees to update the file modification time after closing the last write file handle. On Windows (and on Windows only) the file time is then copied along when copying the 'current' save file to the save slot.

Short term solutions:

Manually set the modification of the save slot file after copying.
Store the time in the save file. We don't want to change the save file format at this point, but could use some of the (currently zeroed-out) padding the in pld struct. We'd still need to do (1.) for backwards compatibility though, as well as use the file time when the new pld field is zero.

Long term solution:

We don't really need to keep the 'current' save file on disk, it's only a few MB max. Instead we could load the whole file into memory and then write directly to the save slot when saving. This would also fix issues encountered when running multiple instances of AL at the same time (possibly what caused Bug report 582 - After meteor scene(where u cannot destroy it) and leaving temple game starts all over again!!!).

#9

Comment posted on behalf of

Eli2

Mar 04, 03:19

The issue was updated with the following change(s):

The status has been updated, from Investigating to Confirmed.
The assignee has been changed to Not assigned.

#10

Comment posted on behalf of

Daniel Scharrer

May 05, 20:21

The issue was updated with the following change(s):

The priority has been updated, from Not determined to Regression.

#11

Reply

Comment posted by

Daniel Scharrer

Aug 06, 12:04

Crash report 628 - [DE2A632C] arx.exe!MenuCursor::DrawOneCursor() [menuwidgets.cpp:4931] could also be related to this (see logs).

#12

Reply

Comment posted by

Daniel Scharrer

Apr 28, 14:27

Could be related:

#13

Comment posted on behalf of

Daniel Scharrer

Jun 04, 17:20

The issue was updated with the following change(s):

The custom field OS has been updated to Windows.

#14

Comment posted on behalf of

Daniel Scharrer

Jul 07, 01:46

This issue has been updated with the latest changes from the code repository.

Windows: Update file time in fs::copy_file
 
This matches the POSIX implementation, which needs to manually read the
source file and write the destination file.
 
Fixes: bug #598

#15

Reply

Comment posted by

Daniel Scharrer

Jul 14, 04:41

This should be fixed in the latest development snapshot (1.2-dev-2015-07-14), please test.

#16

Comment posted on behalf of

Daniel Scharrer

Jul 14, 04:41

The issue was updated with the following change(s):

This issue has been closed
The status has been updated, from Confirmed to Closed.
The resolution has been updated, from Not determined to RESOLVED.
Information about the user working on this issue has been changed, from Eli2 to Not being worked on.
Time spent on this issue, from No time spent to 73 weeks, 5 days, 1 hour.
This issue's progression has been updated to 100 percent completed.

#17

Comment posted on behalf of

Daniel Scharrer

Jul 14, 04:41

The issue was updated with the following change(s):

The status has been updated, from Closed to New.
This issue has been reopened
The resolution has been updated, from RESOLVED to Not determined.
This issue's progression has been updated to 0 percent completed.

#18

Comment posted on behalf of

Daniel Scharrer

Jul 14, 04:41

The issue was updated with the following change(s):

This issue has been closed
The status has been updated, from New to Fixed.
The resolution has been updated, from Not determined to RESOLVED.
This issue's progression has been updated to 100 percent completed.

#19

Comment posted on behalf of

Daniel Scharrer

Jul 14, 04:44

The issue was updated with the following change(s):

The custom field Fixed in has been updated, from Unknown to Arx Libertatis Git.

#20

Comment posted on behalf of

Daniel Scharrer

Jul 14, 04:44

The issue was updated with the following change(s):

The custom field Fixed in has been updated, from Arx Libertatis Git to Unknown.

#21

Reply

Comment posted by

Tafferwocky

Jul 14, 21:04

Tested Windows 7 x64, 14/7/15 snapshot- issue is fixed with both quicksaves and normal saves. Thanks!

#22

Comment posted on behalf of

Daniel Scharrer

Jul 19, 14:00

This issue has been updated with the latest changes from the code repository.

Windows: Update file time in fs::copy_file
 
This matches the POSIX implementation, which needs to manually read the
source file and write the destination file.
 
Fixes: bug #598

* Username
* Display name
The "display name" is the name shown to others
Real name
* E-mail address
* Confirm e-mail

Welcome to The Bug Genie

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Really delete this comment?

Username
Password