Arx Libertatis Bug Tracker
star_faded.png
Please log in to bookmark issues
bug_report_small.png
CLOSED  Bug report #702  -  Build fails with glm 0.9.6.1
Posted Jan 10, 2015 - updated Jan 24, 2015   Shortlink: http://arx.vg/702
action_vote_minus_faded.png
0
Votes
 action_vote_plus_faded.png
icon_info.png This issue has been closed with status "Fixed" and resolution "RESOLVED".
Issue details
  • Type of issue
    Bug report
  • Status
     
    		 Fixed
  • Assigned to
    Not assigned to anyone
  • Progress
       
  • Type of bug
    Not triaged
  • Likelihood
    Not triaged
  • Effect
    Not triaged
  • Posted by
    CrumblingStatue
  • Owned by
    Not owned by anyone
  • Estimated time
    Not estimated
  • Time spent
    6 days, 10 hours
  • Category
    Not determined
  • Resolution
    RESOLVED
  • Priority
    Not determined
  • Reproducability
    Always
  • Severity
    Not determined
  • Targetted for
    icon_milestones.png Not determined
  • OS
    icon_customdatatype.png Not determined
  • Architecture
    icon_customdatatype.png Not determined
  • Fixed in
    icon_customdatatype.png Not determined
Issue description
The tvec* types seem to have been moved out of the detail namespace, up one level. 

  1. In file included from .../ArxLibertatis/src/core/Localisation.cpp:29:
  2. In file included from .../ArxLibertatis/src/core/Config.h:29:
  3. .../ArxLibertatis/src/math/Types.h:60:67: error: no template named 'tvec2' in namespace 'glm::detail'; did you mean 'glm::tvec2'?
  4. template <class T> struct vec2_traits : public vec_traits_base<T, glm::detail::tvec2, 2>{};
  5.                                                                   ^~~~~~~~~~~~~~~~~~
  6.                                                                   glm::tvec2
  7. /usr/include/glm/detail/type_vec2.hpp:49:9: note: 'glm::tvec2' declared here
  8.         struct tvec2
  9.                ^
  10. In file included from .../ArxLibertatis/src/core/Localisation.cpp:29:
  11. In file included from .../ArxLibertatis/src/core/Config.h:29:
  12. .../ArxLibertatis/src/math/Types.h:61:67: error: no template named 'tvec3' in namespace 'glm::detail'; did you mean 'glm::tvec3'?
  13. template <class T> struct vec3_traits : public vec_traits_base<T, glm::detail::tvec3, 3>{};
  14.                                                                   ^~~~~~~~~~~~~~~~~~
  15.                                                                   glm::tvec3
  16. /usr/include/glm/detail/type_vec3.hpp:49:9: note: 'glm::tvec3' declared here
  17.         struct tvec3
  18.                ^
  19. In file included from .../ArxLibertatis/src/core/Localisation.cpp:29:
  20. In file included from .../ArxLibertatis/src/core/Config.h:29:
  21. .../ArxLibertatis/src/math/Types.h:62:67: error: no template named 'tvec4' in namespace 'glm::detail'; did you mean 'glm::tvec4'?
  22. template <class T> struct vec4_traits : public vec_traits_base<T, glm::detail::tvec4, 4>{};
  23.                                                                   ^~~~~~~~~~~~~~~~~~
  24.                                                                   glm::tvec4
  25. /usr/include/glm/detail/type_vec4.hpp:103:9: note: 'glm::tvec4' declared here
  26.         struct tvec4
  27.                ^
  28. 3 errors generated.

This patch fixes the build for me, but it might break things on different configurations: 
  1. diff --git a/src/math/Types.h b/src/math/Types.h
  2. index 5c977b1..2eb350f 100644
  3. --- a/src/math/Types.h
  4. +++ b/src/math/Types.h
  5. @@ -57,9 +57,9 @@ typedef Rectangle_<float> Rectf;
  6.  #endif
  7.  
  8.  
  9. -template <class T> struct vec2_traits : public vec_traits_base<T, glm::detail::tvec2, 2>{};
  10. -template <class T> struct vec3_traits : public vec_traits_base<T, glm::detail::tvec3, 3>{};
  11. -template <class T> struct vec4_traits : public vec_traits_base<T, glm::detail::tvec4, 4>{};
  12. +template <class T> struct vec2_traits : public vec_traits_base<T, glm::tvec2, 2>{};
  13. +template <class T> struct vec3_traits : public vec_traits_base<T, glm::tvec3, 3>{};
  14. +template <class T> struct vec4_traits : public vec_traits_base<T, glm::tvec4, 4>{};
  15.  
  16.  template <class T, int N> struct vec_traits {};
  17.  template <class T> struct vec_traits<T, 2> : public vec2_traits<T>{};

Steps to reproduce this issue
Nothing entered.

#3
icon_reply.pngReply
Comment posted by
HelenWong
Jan 22, 20:17
For my future reference

check wich glm version changed that, add a few ifdefs and done

there should also be another part in the code with similar checks for reference
#5
icon_reply.pngReply
Comment posted by
Eli2
Jan 24, 18:34
Fixed in http://arx.vg/8cd49a

The issue was updated with the following change(s):
  • This issue has been closed
  • The status has been updated, from New to Fixed.
  • The resolution has been updated, from Not determined to RESOLVED.
  • Information about the user working on this issue has been changed, from HelenWong to Not being worked on.
  • Time spent on this issue, from No time spent to 6 days, 10 hours.
  • The assignee has been changed to Not assigned.
  • This issue's progression has been updated to 100 percent completed.